Raise exception if there is a server error#2
Open
henrypoydar wants to merge 1 commit intohumanshell:masterfrom
Open
Raise exception if there is a server error#2henrypoydar wants to merge 1 commit intohumanshell:masterfrom
henrypoydar wants to merge 1 commit intohumanshell:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today the API was down (but serving a 200 response with a
"{'error':'...'}"body) and the generate method was returningnil, because the #request method just parses the response body and returns the :results key. I think it makes better sense to raise an error in this case rather than have dependent code try and handle a nil, which can happen in all sorts of instances. Added a test for it too.